nx-libs/nx-X11/programs/Xserver/os/access.c, branch pr/render-cleanup

dix: integer overflow in GetHosts() [CVE-2014-8092 2/4]

2015-02-16T04:58:21+00:00

GetHosts() iterates over all the hosts it has in memory, and copies them to a buffer. The buffer length is calculated by iterating over all the hosts and adding up all of their combined length. There is a potential integer overflow, if there are lots and lots of hosts (with a combined length of > ~4 gig). This should be possible by repeatedly calling ProcChangeHosts() on 64bit machines with enough memory. This patch caps the list at 1mb, because multi-megabyte hostname lists for X access control are insane. v2: backport to nx-libs 3.6.x (Mike DePaulo) v3: human-readable version of "1 MB" (Mihai Moldovan) Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Conflicts: os/access.c

Revert "dix: integer overflow in GetHosts() [CVE-2014-8092 2/4]"

2015-02-16T04:55:23+00:00

This reverts commit d4c76981f7fddb364166464c571ed8d3de3086cd.

dix: integer overflow in GetHosts() [CVE-2014-8092 2/4]

2015-02-14T15:14:31+00:00

GetHosts() iterates over all the hosts it has in memory, and copies them to a buffer. The buffer length is calculated by iterating over all the hosts and adding up all of their combined length. There is a potential integer overflow, if there are lots and lots of hosts (with a combined length of > ~4 gig). This should be possible by repeatedly calling ProcChangeHosts() on 64bit machines with enough memory. This patch caps the list at 1mb, because multi-megabyte hostname lists for X access control are insane. v2: backport to nx-libs 3.6.x (Mike DePaulo) Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Conflicts: os/access.c

Imported nx-X11-3.1.0-1.tar.gz

2011-10-10T15:43:39+00:00

Summary: Imported nx-X11-3.1.0-1.tar.gz Keywords: Imported nx-X11-3.1.0-1.tar.gz into Git repository