nx-libs/nx-X11/programs/Xserver/hw/nxagent/compext/Compext.h, branch update-workflows NXv3 (redistributed) https://openid.arctica-project.org/nx-libs/atom?h=update-workflows 2023-04-28T12:39:16+00:00 Update Copyright years 2023-04-28T12:39:16+00:00 Ulrich Sibiller uli42@gmx.de 2022-04-29T19:12:35+00:00 urn:sha1:390887b7487e5a769b2fe2a038404ed47e5c8e91 Addresses ArcticaProject/nx-libs#985 nxagent: fix stack smashing 2020-10-17T20:36:19+00:00 Ulrich Sibiller uli42@gmx.de 2020-10-02T20:11:04+00:00 urn:sha1:ae037701fe9a6337375d51abb2ea5b7aafdb434e In compext Atom has the size of XlibAtom. Therefore calling functions of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow. ==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08 WRITE of size 8 at 0x7fffffffcdc0 thread T0 #0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 #1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202 #2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923 #3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007 #4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595 #5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827 #6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437 #7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403 #8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232 #9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365 #10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350 #11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308 #12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09) Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame #0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190 This frame has 5 object(s): [32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable [96, 100) 'resultFormat' [160, 168) 'ulReturnItems' [224, 232) 'ulReturnBytesLeft' [288, 296) 'pszReturnData' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty ... compext: fix spelling errors as reported by codespell 2018-05-24T07:04:01+00:00 Ulrich Sibiller uli42@gmx.de 2018-04-10T19:12:44+00:00 urn:sha1:781b8a057f1e4e83884c615a7014475cc85f018a Xserver/hw/nxagent/compext: Xfree -> free and Xmalloc -> malloc. 2017-12-15T09:37:02+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2017-12-14T10:15:09+00:00 urn:sha1:d4465b719344c4b241c55779de4d49ed248b243a nxcompext: Move code into Xserver subtree, as nxcompext requires Xserver includes at build time. 2016-11-15T15:38:26+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2016-11-02T23:19:26+00:00 urn:sha1:80b5de3f55fd493ee85f2a78b731ff05e6363e43 Fixes ArcticaProject/nx-libs#276.