nx-libs/nx-X11/programs/Xserver/hw/nxagent/Events.c, branch 3.5.99.25 NXv3 (redistributed) https://openid.arctica-project.org/nx-libs/atom?h=3.5.99.25 2020-11-03T20:47:37+00:00 Events.c: scope improvement 2020-11-03T20:47:37+00:00 Ulrich Sibiller uli42@gmx.de 2020-10-30T18:47:12+00:00 urn:sha1:8b0bb28ebbe5622fc9550543a022b77e24d8a61e Events.c: More cosmetics 2020-10-17T20:38:05+00:00 Ulrich Sibiller uli42@gmx.de 2020-07-27T16:29:40+00:00 urn:sha1:2d99cdd1cf5d8d0e8248d94bc07dca8ff32e4058 Events.c: store parent window from event to meaningful variable 2020-10-17T20:38:05+00:00 Ulrich Sibiller uli42@gmx.de 2020-05-25T16:52:36+00:00 urn:sha1:a4dd6a462d79c5c85ba43923fb5414cef62574f3 Events.c: add some comments/FIXMEs 2020-10-17T20:38:05+00:00 Ulrich Sibiller uli42@gmx.de 2020-05-25T16:49:53+00:00 urn:sha1:ffbc63f918d1ae1f340a67b96f89906ccc88758e Events.c: add more DEBUG output 2020-10-17T20:38:05+00:00 Ulrich Sibiller uli42@gmx.de 2020-05-25T16:36:21+00:00 urn:sha1:337afd839b99733baed52e7b1d01d24c737a8849 nxagent: Prevent resize loop 2020-10-17T20:38:05+00:00 Ulrich Sibiller uli42@gmx.de 2020-05-19T18:59:02+00:00 urn:sha1:8deda7bd4f1ada976010c2edcd7cab9a4bdf8140 This only happened with certain window managers like mutter. Fixes ArcticaProject/nx-libs#925 nxagent: fix stack smashing 2020-10-17T20:36:19+00:00 Ulrich Sibiller uli42@gmx.de 2020-10-02T20:11:04+00:00 urn:sha1:ae037701fe9a6337375d51abb2ea5b7aafdb434e In compext Atom has the size of XlibAtom. Therefore calling functions of Compext.c requires to use/pass XlibAtom. Same for Window/XlibWindow. ==15438==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdc0 at pc 0x5555556a81b5 bp 0x7fffffffcd10 sp 0x7fffffffcd08 WRITE of size 8 at 0x7fffffffcdc0 thread T0 #0 0x5555556a81b4 in NXGetCollectedProperty nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 #1 0x5555557d0488 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1202 #2 0x555555723340 in nxagentHandleCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3923 #3 0x55555571d4db in nxagentHandleProxyEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:3007 #4 0x55555571bb92 in nxagentHandleClientMessageEvent nx-X11/programs/Xserver/hw/nxagent/Events.c:2595 #5 0x555555717dfc in nxagentDispatchEvents nx-X11/programs/Xserver/hw/nxagent/Events.c:1827 #6 0x555555750813 in nxagentBlockHandler nx-X11/programs/Xserver/hw/nxagent/Handlers.c:437 #7 0x5555556c1b5d in BlockHandler nx-X11/programs/Xserver/dix/dixutils.c:403 #8 0x5555556d47ff in WaitForSomething nx-X11/programs/Xserver/os/WaitFor.c:232 #9 0x555555665b22 in Dispatch nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:365 #10 0x5555555ed760 in main nx-X11/programs/Xserver/dix/main.c:350 #11 0x7ffff604909a in __libc_start_main ../csu/libc-start.c:308 #12 0x5555555edc09 in _start (nx-X11/programs/Xserver/nxagent+0x99c09) Address 0x7fffffffcdc0 is located in stack of thread T0 at offset 32 in frame #0 0x5555557d0324 in nxagentCollectPropertyEvent nx-X11/programs/Xserver/hw/nxagent/Clipboard.c:1190 This frame has 5 object(s): [32, 36) 'atomReturnType' <== Memory access at offset 32 partially overflows this variable [96, 100) 'resultFormat' [160, 168) 'ulReturnItems' [224, 232) 'ulReturnBytesLeft' [288, 296) 'pszReturnData' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow nx-X11/programs/Xserver/hw/nxagent/compext/Compext.c:4124 in NXGetCollectedProperty ... nxagent: Add keystroke for dumping the current clipboard state 2020-05-31T10:52:35+00:00 Ulrich Sibiller uli42@gmx.de 2020-02-13T23:28:59+00:00 urn:sha1:b82f44e3565b6670e816f4081076596d0ea0236b Improve clipboard/xfixes related debug output 2020-05-07T12:58:17+00:00 Ulrich Sibiller uli42@gmx.de 2019-06-24T13:45:20+00:00 urn:sha1:27933a8d87d759e42a1c2d58a54af1ba99f8455c Clipboard.c: rename some exported functions 2020-05-07T12:57:21+00:00 Ulrich Sibiller uli42@gmx.de 2020-02-14T22:59:45+00:00 urn:sha1:a94fef86c9ee72d646813f58bf947f7f245ebbca to make them all fit in the same naming scheme that better describes their purpose.