nx-libs/nx-X11/lib/X11/lcFile.c, branch update-workflows

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

drop platform support: unifdef UNIXOS2.

2017-02-08T21:40:46+00:00

Fixes ArcticaProject/nx-libs#271.

libX11: rm redundante NULL checks

2016-10-19T19:40:29+00:00

This patch removes the last remaining NULL checks for Xfree() Signed-off-by: Harms Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer Backported-to-NX-by: Ulrich Sibiller

xlibi18n: fix argsize argument to _XlcParsePath

2016-10-19T19:40:28+00:00

The array is defined as having NUM_LOCALEDIR entries, so use that instead of hardcoded 256 value (the other two calls already did this). Reported by parfait: Buffer overflow (CWE 120): In pointer dereference of argv[argc] with index argc Pointer size is 64 elements (of 8 bytes each), index is 255 at line 82 of nx-X11/lib/X11/lcFile.c in function 'parse_line'. called at line 178 in function '_XlcParsePath' with argv = argv. called at line 722 in function '_XlcLocaleLibDirName' with argv = args, argsize = 256. at line 82 of nx-X11/lib/X11/lcFile.c in function 'parse_line'. called at line 178 in function '_XlcParsePath' with argv = argv. called at line 638 in function '_XlcLocaleDirName' with argv = args, argsize = 256. [ This bug was found by the Parfait 1.2.0 bug checking tool. http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ] Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Constify lc_name argument to _XlcLocaleDirName() & _XlcLocaleLibDirName()

2016-10-19T19:40:28+00:00

Makes code considerably less crufty and clears gcc warnings: XlcDL.c: In function '_XlcDynamicLoad': XlcDL.c:384:44: warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual] XlcDL.c:386:51: warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual] Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xlibi18n: convert sprintf calls to snprintf

2016-10-19T19:40:28+00:00

Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb Backported-to-NX-by: Ulrich Sibiller

lcfile: skip over any null entries in args list

2016-10-19T19:40:28+00:00

Previous code seemed to assume that printf("%s", NULL) would result in a 0-length string, not "(null)" or similar, but since there's no point looking for files in "(null)/filepath...", instead we just skip over NULL entries in search paths when generating file names. In the *DirName() functions, this effectively just moves the "bail on NULL in arg[i]" check up from the later code that assigned it to targetdir and then bailed if that was NULL. Not sure how there ever could be a NULL in arg[i], given the current implementation of XlcParsePath, but it's easy enough to check once and reject up front instead of on every reference. Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Align files with upstream libX11-1.6.0

2016-10-19T19:40:27+00:00

This commit looks a bit crazy at first glance. It (re-)introduces lots of whitespaces and bad formatting. Explanation: Backporting upstream changes lead to commits being applied out of order. This meant a lot of manual intervention which in turn lead to slight differences between upstream and NX. With this commit these slight differences are minimized which will be of great help when adding further upstream patches.

Convert malloc(strlen()); strcpy() sets to strdup

2016-10-19T19:40:25+00:00

Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston Backported-to-NX-by: Ulrich Sibiller

xlibi18n/lcFile: Removed superfluous check for NULL target_dir

2016-10-19T19:40:24+00:00

The situation is already handled before this code. Cannot reach dead expression "0U" inside statement "if (1U + (target_dir ? strl..." Reviewed-by: Alan Coopersmith Reviewed-by: Ander Conselvan de Oliveira Signed-off-by: Erkki Seppälä Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

nx-libs/nx-X11/lib/X11/lcFile.c, branch update-workflows

Convert nx-X11/lib/ build flow from imake to autotools.

drop platform support: unifdef __UNIXOS2__.

libX11: rm redundante NULL checks

xlibi18n: fix argsize argument to _XlcParsePath

Constify lc_name argument to _XlcLocaleDirName() & _XlcLocaleLibDirName()

xlibi18n: convert sprintf calls to snprintf

lcfile: skip over any null entries in args list

Align files with upstream libX11-1.6.0

Convert malloc(strlen()); strcpy() sets to strdup

xlibi18n/lcFile: Removed superfluous check for NULL target_dir

drop platform support: unifdef UNIXOS2.