nx-libs/nx-X11/lib/X11/LRGB.c, branch 3.5.99.18

Convert nx-X11/lib/ build flow from imake to autotools.

2017-08-25T08:06:49+00:00

LRGB.c: Fix label defined but not used

2016-10-20T08:16:35+00:00

LRGB.c: In function ‘LINEAR_RGB_InitSCCData’: LRGB.c:798:1: warning: label ‘FreeBlueTblElements’ defined but not used [-Wunused-label] FreeBlueTblElements: ^

xcms: use size_t for pointer offsets passed to strncmp

2016-10-19T19:40:30+00:00

instead of converting to int and back Fixes clang warnings of the form: HVC.c:190:43: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion] if (strncmp(spec, _XcmsTekHVC_prefix, n) != 0) { ~~~~~~~ Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xcms: use unsigned indexes when looping through unsigned values

2016-10-19T19:40:30+00:00

Clears many gcc warnings of the form: uvY.c: In function ‘XcmsCIEuvYToCIEXYZ’: uvY.c:263:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < nColors; i++, pColor++) { ^ Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

Remove unnecessary casts of pointers to (char *) in calls to Xfree()

2016-10-19T19:40:28+00:00

Left one cast behind that is necessary to change from const char * to char * in nx-X11/lib/X11/lcCharSet.c. Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xcms: Fix memory leaks on LINEAR_RGB_InitSCCData error path.

2016-10-19T19:40:25+00:00

pScreenData is replaced when building per visual intensity tables. If malloc failed the old value of pScreenData (stored also in pScreenDefaultData) was being leaked. Also, property_return wasn't free'd in that case. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xcms: Fix error on LINEAR_RGB_InitSCCData error path.

2016-10-19T19:40:25+00:00

Due to what looks like a copy & paste error, pScreenData->pBlueTbl would be accessed after being free'd. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xcms/LRGB: don't double-free property_return

2016-10-19T19:40:24+00:00

property_return was free'd before and in the case the conditional is true, the call to XcmsGetProperty failed which means that property_return wasn't set so there is no need to free it again. Double free of pointer "property_return" in call to "free" Reviewed-by: Alan Coopersmith Reviewed-by: Erkki Seppälä Signed-off-by: Ander Conselvan de Oliveira Backported-to-NX-by: Ulrich Sibiller

xcms/LRGB: Add a label for freeing property_return.

2016-10-19T19:40:24+00:00

The rest of the code uses goto's to free memory allocated later and prevent memory leaks, but there were several paths were property_return was free'd just before a goto. Reviewed-by: Alan Coopersmith Signed-off-by: Ander Conselvan de Oliveira Signed-off-by: Erkki Seppälä Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller

xcms/LRGB: Fix potential resource leak.

2016-10-19T19:40:24+00:00

property_return was not free'd if the allocation of pRedTbl failed. Reviewed-by: Erkki Seppälä Signed-off-by: Ander Conselvan de Oliveira Signed-off-by: Alan Coopersmith Backported-to-NX-by: Ulrich Sibiller