libayatana-indicator/libindicator/indicator-object.c, branch 0.5.0 Ayatana Indicators Shared Library https://openid.arctica-project.org/libayatana-indicator/atom?h=0.5.0 2012-02-29T20:58:03+00:00 silence Coverity warning "PW.BRANCH_PAST_INITIALIZATION - CID 10615" reported in Bug #939061 2012-02-29T20:58:03+00:00 Charles Kerr charles.kerr@canonical.com 2012-02-29T20:58:03+00:00 urn:sha1:9e2278a994df1d5a237e4f21bc191965323653c9 Coverity is unhappy that the local variable "priv" is uninitialized if one of the goto branches is followed in this function. Since we only use priv once, a fairly clean way of sidestepping this warning is removing the local variable "priv" and instead using INDICATOR_OBJECT_GET_PRIVATE()'s return pointer directly. tweak: use g_clear_object() instead of if-not-null-g_object_unref() 2012-02-29T20:55:23+00:00 Charles Kerr charles.kerr@canonical.com 2012-02-29T20:55:23+00:00 urn:sha1:b6454804274860b4716ed6eae826a340e87408d0 Removing unenforcable consts 2012-02-22T18:18:01+00:00 Ted Gould ted@gould.cx 2012-02-22T18:18:01+00:00 urn:sha1:975ee36fd391d7b9c75289dc306267b5acbd3882 indicator_object_dispose: remove unneeded list of entries 2012-02-13T18:38:10+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-02-13T18:38:10+00:00 urn:sha1:b2ca0dbe7704098144b6ccd103dd760ad7dd3636 indicator_object_dispose: use _set_visible instead of reimplementing it 2012-02-13T18:15:03+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-02-13T18:15:03+00:00 urn:sha1:73c0659d30445a2202faf1d0b87c2464f02b51e3 indicator_object_set_visible: no need to check for ENTRY_INIT 2012-02-13T18:08:27+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-02-13T18:08:27+00:00 urn:sha1:e7780ac9f99dda5fea04721be0b2b26050442c8c indicator_object_set_visible: only emit entry-{added,removed} when visibility actually changed 2012-02-12T12:40:21+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-02-12T12:40:21+00:00 urn:sha1:5f599a8cabbbc451e6c0846598453eb2618d4405 Emitting those signals is semantically incorrect. It also confused indicator-loader and the panel, because they are not checking whether an entry is already present in their entry-added handlers. This led to gtk warnings ("widget already has a parent") and strange effects, such as the same menu being added multiple times into the panel. IndicatorObject: update object parent in any case. 2012-01-25T17:10:29+00:00 Marco Trevisan (Treviño) mail@3v1n0.net 2012-01-25T17:10:29+00:00 urn:sha1:1baaf2880f44fea4519f323e3da425318af6c688 Indicator-Object: update the parent_object value only if the entry is valid. 2012-01-25T11:21:51+00:00 Marco Trevisan (Treviño) mail@3v1n0.net 2012-01-25T11:21:51+00:00 urn:sha1:c9df18becfc38ab3e3a833d0095c26f5140800e1 IndicatorObject: correctly initialize the parent object. 2012-01-25T10:55:37+00:00 Marco Trevisan (Treviño) mail@3v1n0.net 2012-01-25T10:55:37+00:00 urn:sha1:0373d6fcb3f7b62028db4978ba215c403b43fed9