ayatana-indicator-messages/src/ido-menu-item.c, branch 0.8.0 Ayatana Indicator Messages Applet https://openid.arctica-project.org/ayatana-indicator-messages/atom?h=0.8.0 2013-07-30T12:50:52+00:00 Remove panel plugin 2013-07-30T12:50:52+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2013-07-30T12:50:52+00:00 urn:sha1:3b39985ac5acdd739643e3d8b0c5f2e80548ef97 Set the global chat status more intelligently 2012-09-18T19:54:37+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-09-18T19:54:37+00:00 urn:sha1:24ee0b6602960f35712adbf668099e06b8ebfb25 Up until now, the global chat status was set every time an application called _set_status. Thus, global status really meant "status of the app that last changed the status". Now, the service remembers the chat status for each application and sets the global status as a combination of all of application statuses. If applications have different statuses, the menu items are shown in an inconsistent state. This is implemented in IdoMenuItem by making it accept state as an array of strings in addition to a single string. It is drawn inconsistent if the state contains the menu item's target value in addition to other values. When the global status is changed through the messaging menu, the service doesn't update the action immediately anymore. Instead, it notifies all applications about the change via the "status-changed" signal. Applications must call _set_state to acknowledge that they have indeed changed their state. This is consistent with libmessaging-menu's documentation and design. Also, the SetStatus D-Bus call was missing a "desktop-id" parameter to tell the menu which application changed status. Changing this doesn't break existing apps, as the D-Bus interface is considered private to indicator-messages. ido_menu_item_set_menu_item: make sure g_free isn't called with dangling pointer 2012-08-27T15:30:22+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T15:30:22+00:00 urn:sha1:90fdd58aafdc8e8d8f2537acf2c1800a76a8378e IdoMenuItem: clear target pointer in dispose 2012-08-27T15:22:53+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T15:22:53+00:00 urn:sha1:99373eb1ab1ce5aa293857625ccbe53211cd38ee Increase spacing between icons and labels 2012-08-27T14:42:05+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T14:42:05+00:00 urn:sha1:c3bbc027e18bf05520b7a94127da20338855c535 Indent application shortcuts 2012-08-27T14:34:16+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T14:34:16+00:00 urn:sha1:29252e90c642281aeaae41640acd6db450383624 This is done by setting their icon to the empty string, which IdoMenuItem interprets as "show a clear icon". IdoMenuItem: don't try to set state on stateless actions 2012-08-27T14:13:36+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T14:13:36+00:00 urn:sha1:5c88df7dcff3fcb98507a9b1c073bb5b23e1487d Show icons on status menu items 2012-08-27T13:38:04+00:00 Lars Uebernickel lars.uebernickel@canonical.com 2012-08-27T13:38:04+00:00 urn:sha1:fab67a704ed6f189014a1988e641194e0f4babb1 This introduces IdoMenuItem, a GtkCheckMenuItem that can also show icons. This should go into libido at some point. Also, Im{App,Source}MenuItem could derive from it so that the GMenuItem-setting logic is only in one place.